Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow avatar name to be composed entirely of whitespace #1231

Merged
merged 2 commits into from
Oct 3, 2018
Merged

Allow avatar name to be composed entirely of whitespace #1231

merged 2 commits into from
Oct 3, 2018

Conversation

legrego
Copy link
Member

@legrego legrego commented Oct 3, 2018 •
edited by cchaos
Loading

Summary

Fixes case where EuiAvatar's name is composed entirely of whitespace. Fixes #1230

Checklist

- [ ] This was checked in mobile

  • This was checked in IE11
  • This was checked in dark mode
    - [ ] Any props added have proper autodocs
    - [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
    - [ ] This was checked against keyboard-only and screenreader scenarios

cchaos
cchaos approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@legrego legrego merged commit 2bec11b into elastic:master Oct 3, 2018
@legrego legrego deleted the fix-avatar-crash branch October 3, 2018 14:51
@snide snide mentioned this pull request Oct 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legrego @cchaos